Repository navigation
build: vendor libdiffpy as cmake project - #105
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 98.68% 98.69%
=======================================
Files 26 26
Lines 3885 3834 -51
=======================================
- Hits 3834 3784 -50
+ Misses 51 50 -1
🚀 New features to boost your workflow:
|
Contributor
Author
|
@sbillinge PR ready for review |
Contributor
|
@SYMSCAE I merged this. Is it ready for another rc release? |
Contributor
Author
Sure thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up commit to diffpy/libdiffpy#75, this changes srreal side.
Matrix results are at https://github.com/SYMSCAE/diffpy.srreal/actions/runs/42326300798.